search

InsertKoinIO / koin-annotations

Koin Annotations - About Koin - a pragmatic lightweight dependency injection framework for Kotlin & Kotlin Multiplatform insert-koin.io
https://insert-koin.io
Apache License 2.0
163 stars 44 forks source link

Add import for the module class when created without a package #163

Open kibettheophilus opened 3 months ago

kibettheophilus commented 3 months ago

Fixes #153

arnaudgiuliani commented 2 months ago

Seems to break defaultModule generation 🤔 image

Check examples folder and try generate default modules.

arnaudgiuliani commented 2 months ago

Also provide a test case 👍

kibettheophilus commented 2 months ago

Seems to break defaultModule generation 🤔 image

Check examples folder and try generate default modules.

@arnaudgiuliani I have pushed an update to fix this

arnaudgiuliani commented 2 months ago

Seems to build ✅ 🎉 Can you add a test case in one of the example apps?

kibettheophilus commented 2 months ago

Seems to build ✅ 🎉 Can you add a test case in one of the example apps?

@arnaudgiuliani added a module on the root package and the existing test, not sure if that is enough.

arnaudgiuliani commented 1 month ago

Perfect 👌

arnaudgiuliani commented 1 month ago

build failed, will look at it

kibettheophilus commented 1 month ago

build failed, will look at it

Great, will also try have a look at it.

arnaudgiuliani commented 1 month ago

seems to be that:

e: file:///Users/runner/work/koin-annotations/koin-annotations/examples/android-coffee-maker/build/generated/ksp/debug/kotlin/org/koin/ksp/generated/RootModuleGen.kt:8:12 Type expected

e: file:///Users/runner/work/koin-annotations/koin-annotations/examples/android-coffee-maker/build/generated/ksp/debug/kotlin/org/koin/ksp/generated/RootModuleGen.kt:8:23 Property getter or setter expected

kibettheophilus commented 1 month ago

So it finally build without any updates😅.