search

InsertKoinIO / koin

Koin - a pragmatic lightweight dependency injection framework for Kotlin & Kotlin Multiplatform
https://insert-koin.io
Apache License 2.0
9.08k stars 719 forks source link

missing watchosDeviceArm64 target #1747

Closed suau closed 9 months ago

suau commented 10 months ago

Describe the bug Since XCode14 the ARCHS_STANDARD for watchOS includes arm64. KMP already has added the target watchosDeviceArm64, but koin hasn't included it yet

To Reproduce Steps to reproduce the behavior:

  1. Create a KMP project
  2. Add Koin
  3. Add a watchOS app to the ios app
  4. Add watchosArm64(), watchosDeviceArm64(), watchosSimulatorArm64() to the shared build.gradle.kts
  5. Build for release
  6. Release build will fail with default settings

Expected behavior watchos should build with default settings

Koin module and version: koin-core:3.5.3

arnaudgiuliani commented 9 months ago

Thanks, let's continue with the PR 👍