koin-compose: use rememberUpdatedState with ParametersDefinition, optimized KoinApplication, KoinContext, KoinIsolatedContext

InsertKoinIO / koin

Koin - a pragmatic lightweight dependency injection framework for Kotlin & Kotlin Multiplatform

https://insert-koin.io

Apache License 2.0

9.08k stars 719 forks source link

Closed hoc081098 closed 7 months ago

hoc081098 commented 9 months ago

use rememberUpdatedState with ParametersDefinition
delegate rememberKoinInject to koinInject, update deprecated message (will close https://github.com/InsertKoinIO/koin/issues/1743)
optimized KoinApplication, KoinContext, KoinIsolatedContext
remove unused UnknownKoinContext
apiDump

arnaudgiuliani commented 9 months ago

is it optimizing around rememberUpdatedState? What is the target of this PR?

hoc081098 commented 9 months ago

is it optimizing around rememberUpdatedState? What is the target of this PR?

I have used rememberUpdatedState to make sure scope.get... will use the latest ParametersDefinition (but it does not cause unnecessary recomposition 🙏).

Previous code has an issue where scope.get(...) use the old ParametersDefinition, since it is remembered.

I have also refactored KoinContext, KoinApplication, ... Basically, I have replaced CompositionLocalProvider (...){ content() } with CompositionLocalProvider(..., content = content)
apiDump and some format changes as well

arnaudgiuliani commented 9 months ago

Good work. I need to take time to take a tour :)

arnaudgiuliani commented 7 months ago

It's just a api diff confilct I believe @hoc081098 👍

hoc081098 commented 7 months ago

It's just a api diff confilct I believe @hoc081098 👍

I will update it 🙏

arnaudgiuliani commented 7 months ago

done edit for you @hoc081098 👍

hoc081098 commented 7 months ago

done edit for you @hoc081098 👍

Thanks for your help