search

InsertKoinIO / koin

Koin - a pragmatic lightweight dependency injection framework for Kotlin & Kotlin Multiplatform
https://insert-koin.io
Apache License 2.0
8.76k stars 695 forks source link

Upgrading Koin `3.5.3` -> `3.5.4` removes dep on `kotlin-test` #1848

Closed yogurtearl closed 2 months ago

yogurtearl commented 2 months ago

PR https://github.com/InsertKoinIO/koin/pull/1802 removes kotlin-test as a transitive dependency.

It is a good change, but also a breaking change which should probably be saved for a major version bump (or minor), not added in a patch release.

This is will break anyone that was relying on kotlin-test at compile or runtime (which they shouldn't have been doing in the first place, but https://xkcd.com/1172/ )

The solution is to add something like testImplementation("org.jetbrains.kotlin:kotlin-test:$kotlinVersion")

Mostly just opening this for documentation purposes, feel free to close it.

arnaudgiuliani commented 2 months ago

problem is some side impact of complete rewrite of Gradle Kotlin DSL 🙄 This is why I asked feedback on RC releases :)