Few bug fixes and enhancements

JoyceBabu commented 6 years ago

I have fixed a few bugs and added option to specify custom price granularity. Sorry about the single pull request for multiple changes.

Bugs

Comparison of floating point numbers was not working as expected when generating value buckets. I am not sure whether this has something to do with my PHP installation. But it appears there are other people who have faced similar issues)
$param was being overwritten within for loop in HeaderBiddingScript
Paging through key-value pairs was not working correctly when there are more than SUGGESTED_PAGE_LIMIT entries.
Updated check to prevent the script from attempting to re-create existing key-value pairs (Should fix https://github.com/Insideall/dfp-prebid-lineitems/issues/1 )

Enhancements

Added support for custom price granularity

JoyceBabu commented 5 years ago

Shall I resolve the conflicts and commit?

gchicoye commented 5 years ago

Yes, with pleasure! To be honest, I’m not really experienced in GitHub, I’m a little bit lost, so please got ahead :)

I’ve added on my side Exception Management.

Le 16 oct. 2018 à 08:40, Joyce Babu notifications@github.com a écrit :

Shall I resolve the conflicts and commit?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Insideall/dfp-prebid-lineitems/pull/2#issuecomment-430119018, or mute the thread https://github.com/notifications/unsubscribe-auth/AVSqWNnyFoio5TZW1m5pZ6jD8eGF1tdwks5ulX9PgaJpZM4VvzsG.

Insideall / dfp-prebid-lineitems

Few bug fixes and enhancements #2