Open jp-vanheerden opened 2 months ago
Hey @jp-vanheerden, I don't think that we should be including client specific requirements or changes directly in this repo. The approach should be
a) Can we make articulate the requirement in a way that makes it generic? In this case I would say "yes" and the requirement prob needs to change to add dbt project name or "domain" to the notebook naming conventions to allow multiple dbt_projects to co-exist in one workspace., or
b) If we can't make the requirement generic we may need to make a clone of the repo specifcally for the client and put client specific modifications in there.
@insightgrantkrieger what are your thoughts?
100% agree @jrampono - I was caught up with the excitement of getting this going for Perpetual. I'll change both issues to be a bit more generic
Hi @jrampono I totally agree. This accelerator should be generic enough to be able to go into any new company. Any future requests that come through with company specific requirements we will address and make them generic
Discuss and see if still required
Discuss and see if still required
There should be a configurable naming convention for Master notebooks.
In a scenario where the project is called Investment and there is a naming convention that includes "NB_" as a prefix, the project notebooks could be:
NB_Investment_master_notebook NB_Investment_master_notebook_0