Closed tbirdso closed 2 years ago
I will check if it is due to mesh serialization change.
It looks like the warning was first picked up on March 16th
Yes, I added new Python wrapping for Vector for UL and ULL in the mesh serialization change. Checking if it can be avoided.
UNIQUE(vector_types "UC;F;D;UL;ULL;${WRAP_ITK_SCALAR}")
Strange that the unsigned types warning did not appear for the unsigned char
type. When I rebuild without UL
and ULL
I do not see the warnings, though.
I think I would be in favor of suppressing and ignoring this warning. Users are already expected to be responsible for avoiding overflow with unsigned types such as itk.UL
and the same responsibility should apply when working with vectors. However I would appreciate an additional perspective from @dzenanz or @thewtex .
If we go this route we can suppress the warning by adding a regex string to CTEST_CUSTOM_WARNING_EXCEPTION
in CTestCustom.cmake. We currently do this to suppress a similar warning that appears from VNL vector wrappings.
I am building it without those additional wrappings however, it failed previously. If we can't do without those wrappings then yes we have to do something similar to what you are suggesting.
Green again for Windows Python!
Thank you @PranjalSahu !
Description
Compiling ITK Python wrappings on Windows produces a warning about unsigned vector operations. It is unclear what change introduced this warning.
Steps to Reproduce
Compile ITKCommon Python wrappings on Windows.
Expected behavior
No warnings
Actual behavior
Reproducibility
100%
Versions
Environment
Windows 10
Additional Information
CDash results