search

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.4k stars 662 forks source link

Identifier `SAGITAL_PLANE` is misspelled #3923

Open dzenanz opened 1 year ago

dzenanz commented 1 year ago

The identifier SAGITAL_PLANE might also be misspelled 🤔 That was beyond the scope of this pull request:

_Originally posted by @N-Dekker in https://github.com/InsightSoftwareConsortium/ITK/pull/3921#discussion_r1103808432_

dave3d commented 1 year ago

I can fix this and submit a PR.

dzenanz commented 1 year ago

There is a complication: we might want to have a backwards compatible misspelled name when ITK_LEGACY_REMOVE is OFF.

dave3d commented 1 year ago

There is a complication: we might want to have a backwards compatible misspelled name when ITK_LEGACY_REMOVE is OFF.

Oh, that is complicated. If you need SAGITAL_PLANE in the Octree enum to remain the same it gets tricky. Probably outside my area of expertise.