Open autoantwort opened 1 year ago
github-actions[bot]
commented
1 year ago Thank you for contributing an issue! 🙏
Welcome to the ITK community! 🤗👋☀️
We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜 Also, please check existing open issues and consider discussion on the ITK Discourse. 📖
This is an automatic message. Allow for time for the ITK community to be able to read the issue and comment on it.
thewtex
commented
1 year ago Hi,
Thanks for the report.
I see
-std=c++14
In the castxml build lines. ITK 5.3 requires C++17. Is there possibly something in the build configuration that is forcing C++14?
autoantwort
commented
1 year ago Is there possibly something in the build configuration that is forcing C++14?
Yeah this line is setting c++14: https://github.com/InsightSoftwareConsortium/ITK/blob/1fc47c7bec4ee133318c1892b7b745763a17d411/CMake/ITKInitializeCXXStandard.cmake#L3
thewtex
commented
1 year ago Is it possible to upgrade to ITK 5.3 or 5.4rc1?
thewtex
commented
1 year ago Note that we do have osx arm wheels: https://pypi.org/project/itk/5.4rc2/#files
Package: itk[core,python]:arm64-osx -> 5.2.1#5
Host Environment
To Reproduce
vcpkg install --enforce-port-checks --allow-unsupportedFailure logs
Details
``` -- Using cached InsightSoftwareConsortium-ITK-95800fd4d4b08678a6c0ebb63eb242893025b660.tar.gz. -- Extracting source /Users/leanderSchulten/git_projekte/vcpkg/downloads/InsightSoftwareConsortium-ITK-95800fd4d4b08678a6c0ebb63eb242893025b660.tar.gz -- Applying patch double-conversion.patch -- Applying patch openjpeg.patch -- Applying patch openjpeg2.patch -- Applying patch var_libraries.patch -- Applying patch wrapping.patch -- Applying patch opencl.patch -- Applying patch use-the-lrintf-intrinsic.patch -- Applying patch dont-build-gtest.patch -- Using source at /Users/leanderSchulten/git_projekte/vcpkg/buildtrees/itk/src/893025b660-829cab57a0.clean -- itk builds a long time (>1h) with python wrappers enabled! -- Found external ninja('1.11.1'). -- Configuring arm64-osx-dbg -- Configuring arm64-osx-rel CMake Warning at vcpkg_installed/arm64-osx/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:314 (message): The following variables are not used in CMakeLists.txt: BUILD_PKGCONFIG_FILES DCMTK_USE_ICU INSTALL_GTEST ITK_USE_SYSTEM_GOOGLETEST ITK_USE_SYSTEM_ICU Module_ITKCudaCommon RTK_BUILD_APPLICATIONS Please recheck them and remove the unnecessary options from the `vcpkg_cmake_configure` call. If these options should still be passed for whatever reason, please use the `MAYBE_UNUSED_VARIABLES` argument. Call Stack (most recent call first): ports/itk/portfile.cmake:126 (vcpkg_cmake_configure) scripts/ports.cmake:147 (include) -- Building arm64-osx-dbg CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message): Command failed: /Users/leanderSchulten/git_projekte/vcpkg/downloads/tools/cmake-3.25.1-osx/cmake-3.25.1-macos-universal/CMake.app/Contents/bin/cmake --build . --config Debug --target install -- -v -j11 Working Directory: /Users/leanderSchulten/git_projekte/vcpkg/buildtrees/itk/arm64-osx-dbg See logs for more information: /Users/leanderSchulten/git_projekte/vcpkg/buildtrees/itk/install-arm64-osx-dbg-out.log Call Stack (most recent call first): vcpkg_installed/arm64-osx/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process) vcpkg_installed/arm64-osx/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build) ports/itk/portfile.cmake:190 (vcpkg_cmake_install) scripts/ports.cmake:147 (include) ```Additional context
vcpkg.json
``` { "$schema": "https://raw.githubusercontent.com/microsoft/vcpkg-tool/main/docs/vcpkg.schema.json", "name": "lichtsteuerung", "version-string": "2.0 $.0", "dependencies": [ { "name": "itk", "default-features": true, "features": [ "python" ] } ], "$overrides": [ { "name": "capstone", "version": "4.0.1-120373dc" } ], "$builtin-baseline": "338f99eed499b6df1628829e40695b396a70a1f7" } ```