Closed N-Dekker closed 5 months ago
@N-Dekker did you confirm that the doxygen build succeeds?
did you confirm that the doxygen build succeeds?
@thewtex I did not try it out locally, but I searched exhaustively for "doxygen.config" in the source tree, and only found it in comments, like:
# The DoxygenConfig.cmake is a replacement for configuring a doxygen.config.in file
Before commit a96d03fb5f4a4bb470516aa623dbc9b4aaaa6e4f (March, 2022), Utilities/Doxygen/CMakeLists.txt still configured doxygen.config.in, by doing:
configure_file(${ITK_SOURCE_DIR}/Utilities/Doxygen/doxygen.config.in
${ITK_BINARY_DIR}/Utilities/Doxygen/doxygen.config)
That statement was removed by commit a96d03fb5f4a4bb470516aa623dbc9b4aaaa6e4f (March, 2022).
@hjmjohnson Can you confirm that "doxygen.config.in" is no longer necessary, now that we have DoxygenConfig.cmake?
This pull request may also be considered as a proof that "doxygen.config.in" is no longer used:
Apparently it was sufficient to add itkVirtualGetNameOfClassMacro
and itkOverrideGetNameOfClassMacro
to "DoxygenConfig.cmake", in order to get GetNameOfClass()
documented at https://itk.org/Doxygen/html/ It is no longer necessary to add such macro's to "doxygen.config.in", because "doxygen.config.in" is ignored anyway, nowadays.
@N-Dekker it needs to be tested before merging. I will start a local build.
The use of doxygen.config has been replaced by DoxygenConfig.cmake, with pull request https://github.com/InsightSoftwareConsortium/ITK/pull/3311 commit a96d03fb5f4a4bb470516aa623dbc9b4aaaa6e4f "COMP: Use modern doxygen_add_docs for BUILD_DOCUMENTAITON", Hans Johnson (@hjmjohnson), March 18, 2022