Closed N-Dekker closed 5 months ago
Windows failure:
The following tests FAILED:
779 - itkConvolutionImageFilterStreamingValidTest (Failed)
test flake?
/azp run ITK.Windows
Did you use some tool to find instances of this?
Well, I did it step by step, "heuristically", starting with a global search of just m_UseImageSpacing == true
, then using regular expressions, ( if \(\w+) == true\)
, ( if \([^ ]+) == true\)
, normal search == true)
, and == true ||
, etc. Until I felt most relevant cases were addressed.
Looking back, I could have done just a brute force find == true
and replace with (nothing). There are only a few == true
cases left now. Not sure if I should also address them.
Not yet addressed:
* \post `m_LetArrayManageMemory == true`
This one is not addressed, but maybe it should, what do you think?
Yes, you could also update that.
FYI While I think this pull request is very much in line with C++ Core Guidelines item "Don’t add redundant ==
or !=
to conditions", I believe it would be helpful if the guideline would explicitly mention such b == true
cases. So I also submitted a pull request to the C++ Core Guidelines 😃 :
Following C++ Core Guidelines, February 15, 2024, "Don’t add redundant
==
or!=
to conditions", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es87-dont-add-redundant--or--to-conditions