DOC: Clarify ThresholdImageFilter behavior

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.

https://itk.org

Apache License 2.0

1.4k stars 661 forks source link

DOC: Clarify ThresholdImageFilter behavior #4511

Closed blowekamp closed 5 months ago

blowekamp commented 5 months ago

PR Checklist

[ ] No API changes were made (or the changes have been approved)
[ ] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for further development details if necessary.

blowekamp commented 5 months ago

Thanks @blowekamp! Glad you fixed the incorrect "between simple threshold values"! Because I think that's the main point of this PR, right? My other two comments are very minor, no show-stopper. Approved! 👍

Yes, that was incorrect and the documentation for the handling of the boundary condition for ThresholdAbove and ThresholdBelow was incorrect too.

N-Dekker commented 5 months ago

@blowekamp If you hadn't merged this one yourself, I would probably have 😄 I was eagerly waiting for permission from the CI 😺