COMP: Use signed char for SobelOperator convolution test

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.

https://itk.org

Apache License 2.0

1.38k stars 661 forks source link

COMP: Use signed char for SobelOperator convolution test #4531

Closed thewtex closed 3 months ago

thewtex commented 3 months ago

In https://github.com/InsightSoftwareConsortium/ITK/commit/03c8176dca4b060ba64ae55f2e5b19426e8fc833 a concept check was added that the sobel operator uses a signed pixel type. On Linux aarch64,

❯ c++ --version c++ (Debian 12.2.0-14) 12.2.0

❯ uname -a Linux deb 6.1.0-18-arm64 #1 SMP Debian 6.1.76-1 (2024-02-01) aarch64 GNU/Linux

char is unsigned, which causes the concept check to fail. Switch char to signed char.

thewtex commented 3 months ago

/azp run ITK.macOS