search

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.38k stars 661 forks source link

WIP (Not ready): Add `GradientImageFilter::OverrideBoundaryCondition(std::unique_ptr<BoundaryConditionType>)` #4533

Open N-Dekker opened 3 months ago

N-Dekker commented 3 months ago

Deprecated the old GradientImageFilter member function OverrideBoundaryCondition(BoundaryConditionType *) in favor of OverrideBoundaryCondition(std::unique_ptr<BoundaryConditionType>).

Aims to make it more clear that the filter takes the ownership of the specified BoundaryCondition object.

Triggered by a comment from Bradley Lowekamp (@blowekamp) at https://github.com/InsightSoftwareConsortium/ITK/pull/4512#discussion_r1523141237

N-Dekker commented 3 months ago

For the record, I started a discussion on how unique_ptr parameters are supported by SWIG, at: