Use unique_ptr for the "pimpl pointers" of GiplImageIO and MINCImageIO

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.

https://itk.org

Apache License 2.0

1.41k stars 663 forks source link

Use unique_ptr for the "pimpl pointers" of GiplImageIO and MINCImageIO #4561

Closed N-Dekker closed 6 months ago

N-Dekker commented 6 months ago

Both "pimpl-like" pointers were already private anyway.

Following C++ Core Guidelines, "Use unique_ptr or shared_ptr to avoid forgetting to delete objects created using new"
Follow-up to pull request https://github.com/InsightSoftwareConsortium/ITK/pull/4539

@thewtex This PR obviously does not affect the public API. It just aims to make the code more secure, by removing two more cases of manual memory management. Would it still be in time for ITK 5.4.0?