STYLE: Revert C++14 workaround when using the constexpr `SupportSize`

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.

https://itk.org

Apache License 2.0

1.41k stars 663 forks source link

STYLE: Revert C++14 workaround when using the constexpr `SupportSize` #4603

Closed N-Dekker closed 4 months ago

N-Dekker commented 5 months ago

C++17 allows using a static constexpr member variable like SupportSize, without being "redeclared". The workaround of copying SupportSize into a local variable is no longer necessary.

Reverts pull request https://github.com/InsightSoftwareConsortium/ITK/pull/2742 commit 27e4815bb816c2cebe3abd0b9aca85afda8101c6 "COMP: Copy BSplineInterpolationWeightFunction::SupportSize within lambda"

N-Dekker commented 5 months ago

👍 Please wait until after v5.4.0 to merge.

Thanks Matt. I think this pull request is ready, but I marked it "draft" to prevent getting merged accidentally, before v5.4.0.

thewtex commented 5 months ago

@N-Dekker perfect! :pray:

thewtex commented 4 months ago

@N-Dekker v5.4.0 has been tagged :rocket: :singer: -- we can merge these drafts when ready.