search

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.37k stars 660 forks source link

BUG: Use unique filenames for Nifti tests #4659

Closed thewtex closed 1 month ago

thewtex commented 1 month ago

When the tests are run in parallel they can try to write to or remove the same file from different processes, causing intermittent failures.

Also add const where it is missing.

Also use full paths as tests inputs, instead of changing directories, which is more explicit.

thewtex commented 1 month ago

@cookpa please take a look

cookpa commented 1 month ago

Thanks for tracking this down @thewtex . The fixes look good to me.

thewtex commented 1 month ago

NIfTI files can be compressed (*.nii.gz) directly to save space, but approving.

Yes, this works locally -- updating.

hjmjohnson commented 1 month ago

@thewtex THANK YOU!