InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.37k stars 660 forks source link

Wunused macros #4673

Closed andrei-sandor closed 1 month ago

andrei-sandor commented 1 month ago

COMP: Fix unused macros related to MSVC and OS

This is to fix the -Wunused-macros generated by clang for macros related to MSVC and Microsoft.

For itkNumericTraitsTest.cxx, the _MSC_VER is added to respect the comment.

For itkTestDriver.cxx, ITK_TEST_DRIVER_PATH_SLASH / is related to non Windows machine and there is none in the code and hence it is removed. Now, for ITK_TEST_DRIVER_PATH_SLASH \, it is not found in the entire code. This is the reason why it is removed.


COMP: Fix unused general macros

This is to fix the -Wunused-macros warning from clang. This is about fixing general macros used in the code.

In the commit, the macros are removed. However, I am wondering if we should comment them since someone might use them in the future.


COMP: Fixed unused legacy remove Macros

This is a commit to solve the Wunused-macros warning generated by clang related to ITK_LEGACY_REMOVE macro.

The change is to create an ifnded macro with it even if ITK_LEGACY_REMOVE is not used in the file. In itkConfigue.h, ITK_LEGACY_REMOVE is defined there if the code is in the legacy remove scenario or not. We need to keep ITK_LEGACY_REMOVE to create a flag that the code is legacy.

seanm commented 1 month ago

/azp.run ITK.Linux