search

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.37k stars 660 forks source link

COMP: Fix -Wextra-semi Warnings for Macro #4679

Closed andrei-sandor closed 1 month ago

andrei-sandor commented 1 month ago

This is to see if the following changes regarding the -Wextra-semi (semi = semicolon) warning of clang can be done throughout the repository.

This is for a macro that is not function-like. It should not contain a semicolon. It is a method that is declared and defined in a header so no semi colon is needed.

Are these following changes accepted to proceed with the other cases in the repository?

seanm commented 1 month ago

This is just a first example of removing the semi-colon for a non-function-like macro (as opposed to a function-like macro).

If there are no objections to this pattern, we'll apply it for other such macros.

thewtex commented 1 month ago

:+1: looks good, thanks!