search

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.37k stars 660 forks source link

COMP: remove suppression of -Winconsistent-missing-override #4682

Closed seanm closed 1 month ago

seanm commented 1 month ago

I tested with AppleClang 10, the oldest AppleClang submitting to cdash, and this false positive seems to have been fixed long ago.

seanm commented 1 month ago

@dzenanz that "ITK.Linux.Python" bot seems to have failed pretty severely, any idea why?

dzenanz commented 1 month ago

/azp run ITK.Linux.Python

dzenanz commented 1 month ago

If a run fails, it is usually the most useful to look at the dashboard. Search for a build which contains the PR number in its name (in this case 4682).

seanm commented 1 month ago

If a run fails, it is usually the most useful to look at the dashboard. Search for a build which contains the PR number in its name (in this case 4682).

Good tip, I've noted in it my notes file.

Seems it was a transient failure and is green now. (There seems to have a lot of these transient failures...)

thewtex commented 1 month ago

@seanm thanks!