search

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.37k stars 660 forks source link

-Wextra-semi #4699

Closed andrei-sandor closed 3 weeks ago

andrei-sandor commented 1 month ago

This is part 2 of if the following changes regarding the -Wextra-semi (semi = semicolon) warning of clang can be done throughout the repository. https://github.com/InsightSoftwareConsortium/ITK/pull/4679

COMP: Remove ; from itkBooleanMacro

COMP: Remove ; from other itk macros

COMP: Updated itkLegacyMacro Definition. We decided to change the definition of itkLegacyMacro to not have two ; if the if defined(ITK_LEGACY_REMOVE) branch is hit.

COMP: Remove ITK_ASSOCIATE ; or struct; Should we remove the semicolon from the struct or from ITK_ASSOCIATE?

COMP: Remove ; to function cases

COMP: Remove cases with ; to override cases

COMP: Remove ; IPL cases

hjmjohnson commented 3 weeks ago

Closing. I think this work is superceeded with updates made in the master branch that elminiates the need to remove the ";" from macros.

seanm commented 2 weeks ago

Some of the commits here are still good, but we'll make a new PR.