search

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.37k stars 660 forks source link

MetaIO 2024-06-20 (eb952d5b) #4738

Closed aylward closed 1 week ago

aylward commented 1 week ago

Code extracted from:

https://github.com/Kitware/MetaIO.git

at commit eb952d5b2dbbccc27a99cc1b4cb27410f5267981 (master).

Extensive (yet backward compatible) changes to MetaIO to fix support for SpatialObjects and support UTF-8 filenames.

See https://github.com/Kitware/MetaIO/issues/127 and https://github.com/Kitware/MetaIO/issues/68

dzenanz commented 1 week ago

Please use the update script: https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/MetaIO/UpdateFromUpstream.sh

aylward commented 1 week ago

Please use the update script: https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/MetaIO/UpdateFromUpstream.sh

I did use that script. It cause the master of MetaIO to be merged into ITK in my forked repo on github. This pull request comes from using the github option to create a commit from the merge done by the script in my fork back to upstream. If there is a different process for this, please let me know.

dzenanz commented 1 week ago

I just created #4739, which retains and updates the MetaIO's separate source tree within the ITK repository.

aylward commented 1 week ago

I just created #4739, which retains and updates the MetaIO's separate source tree within the ITK repository.

Seems redundant and unnecessary

dzenanz commented 1 week ago

Keeping a separate tree for each third party repository makes updating easier, by allowing us to use regular git machinery. I believe @bradking might have come up with the scheme. At the very least, he is the one generally maintaining the update script.

aylward commented 1 week ago

I really think our pull requests do the exact same thing via the exact same script - their names are even exactly the same since they were generated by the same script. But either way is fine with me.

On Fri, Jun 21, 2024 at 10:44 AM Dženan Zukić @.***> wrote:

Keeping a separate tree for each third party repository makes updating easier, by allowing us to use regular git machinery. I believe @bradking https://github.com/bradking might have come up with the scheme. At the very least, he is the one generally maintaining the update script.

— Reply to this email directly, view it on GitHub https://github.com/InsightSoftwareConsortium/ITK/pull/4738#issuecomment-2182892346, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACEJL25VE275ZHPMQ5NEY3ZIQ36JAVCNFSM6AAAAABJV7E7B6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSHA4TEMZUGY . You are receiving this because you authored the thread.Message ID: @.***>

-- Stephen R. Aylward, Ph.D. Chair, MONAI Advisory Board Senior Director, Strategic Initiatives, Kitware

aylward commented 1 week ago

Unsubscribe