thewtex
commented
6 days ago @jhlegarreta thank you for your help with this! :100: :1st_place_medal:
I did not bump the versions for the remotes while opening the PRs. @thewtex let me know your thoughts. Major, minor, patch, none?
I think we should bump the major version. Experience has shown that the packages are not binary compatible across itk major or minor releases. Following semantic versioning, this is a major bump.
In the process of updating these, we could consider also changing the default branch from master to main,
jhlegarreta
Description
Transition remote modules configuration from
setup.pyto the modernpyproject.toml.Impact analysis
pyproject.tomlis the modern way to package projects using Python code: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ https://packaging.python.org/en/latest/guides/modernize-setup-py-project/#modernize-setup-py-projectExpected behavior
Transition all remote module's project configuration to a
pyproject.tomlfile.Actual behavior
Almost all remote module's project configuration dwells in a
setup.pyfile.Versions
N/A.
Environment
N/A.
Additional Information
Matt has contributed with a script that would help in the transition: https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/pull/161
Also, there is this tool Matt has used to update the remote module CI config to ITK 5.4: https://github.com/asottile/all-repos
Ongoing work: https://github.com/thewtex/ITK/commit/9e9d5131dcde8f46505c838218df68ce24701cd0
Remotes and PRs:
Notes:
ITKas a keyword, as well asInsightToolkit, and capitalized the first letter of other keywords. The module template containsitkall lowercase: https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/blob/main/%7B%7Bcookiecutter.project_name%7D%7D/pyproject.toml#L15 Can be a good moment to make these consistent.