COMP: Consolodate compiler version ICE work-arounds

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.

https://itk.org

Apache License 2.0

1.37k stars 660 forks source link

COMP: Consolodate compiler version ICE work-arounds #4754

Closed hjmjohnson closed 4 days ago

hjmjohnson commented 5 days ago

Implement compiler version-specific conditional code selection to facilitate identifying which compilers fail to compile the valid code.

This is an intermediate refactoring so that once all the supported compilers work with the simpler code, we can remove the conditional code.

PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)

seanm commented 4 days ago

It so happens I was working on a similar cleanup of old compiler workarounds. I should share it here in a PR. I was waiting to test it on my oldest bot, with oldest AppleClang...

I think this workaround can just be removed at this point... I'll be back shortly...

hjmjohnson commented 4 days ago

@seanm is working on a more complete solution.