search

InsightSoftwareConsortium / ITK

Insight Toolkit (ITK) -- Official Repository. ITK builds on a proven, spatially-oriented architecture for processing, segmentation, and registration of scientific images in two, three, or more dimensions.
https://itk.org
Apache License 2.0
1.37k stars 660 forks source link

Raise `cmake_minimum_required` in remote modules #4761

Open jhlegarreta opened 3 days ago

jhlegarreta commented 3 days ago

Description

The dashboard is displaying configure warnings related to the cmake_minimum_required version value in remote modules, e.g. https://open.cdash.org/builds/9713834/configure https://open.cdash.org/builds/9713631/configure https://open.cdash.org/builds/9716262/configure

It needs to be updated to 3.16.3 to be up-to-date with ITK, i.e. https://github.com/InsightSoftwareConsortium/ITK/blob/1381ec4c18585ac0e8bdbd580b7b34c0bed9e0d1/CMakeLists.txt#L15 https://github.com/InsightSoftwareConsortium/ITK/blob/1381ec4c18585ac0e8bdbd580b7b34c0bed9e0d1/CMake/ITKModuleExternal.cmake#L13

Impact analysis

Remotes are being packaged with configure warnings.

Expected behavior

No configure warnings are raised.

Actual behavior

Configure warnings are present.

Versions

All HEAD versions of remotes.

Environment

N/A.

Additional Information

Identified while inspecting the dashboard from builds triggered by the changes in issue #4748.

Unfortunately, the GitHub action builds are not reporting these warnings as failures, and thus they may go unnoticed.