search

InsightSoftwareConsortium / ITKCLEsperanto

ITK filters accelerated with OpenCL via [clEsperanto](https://clesperanto.github.io/).
Apache License 2.0
4 stars 3 forks source link

WIP: CLE Filters #42

Closed aaron-bray closed 1 year ago

aaron-bray commented 1 year ago

@tbirdso I am not sure how these python packages are being built, but they seem to be failing to fing the #include "clic.hpp" file, which is generated at CLIc cmake configuration and placed in the binary directory. CMake is not failing... so I assume the compiler (or scikit-build) is not being told to add the CLIc binary directory to its include path? I am not sure how all this automation is working...

tbirdso commented 1 year ago

Hi @aaron-bray , just getting back from vacation. I agree with your analysis. It looks like the CLEsperanto development branch makes clic.hpp configurable via CMake, so adding the build directory include folder to ITKCLEsperanto's include paths seems to have fixed the issue on my local system. Re-running CI now.

In the long term it would be nice to reference a stable CLIc_prototype tag rather than master or development branches, but fine to stick with new features in the development branch for now.

There is one compiler warning in CLIc tests that results in a CI failure, best path forward is probably to turn off building CLIc_prototype tests in ITKCLEsperanto CI.

tbirdso commented 1 year ago

@aaron-bray CI is green after disabling CLIc_prototype tests 👍

aaron-bray commented 1 year ago

@thewtex Please have another review