search

InsightSoftwareConsortium / ITKColorNormalization

Structure preserving color normalization on H&E images using a reference image
Apache License 2.0
18 stars 5 forks source link

`unsigned int` assigned a value of -1 #34

Closed Leengit closed 2 years ago

Leengit commented 2 years ago

Although this seems to work, it should be fixed or commented well why it isn't being fixed.

https://github.com/InsightSoftwareConsortium/ITKColorNormalization/blob/c97b16571d2dbc268a305f8465eb58bc337e83d5/include/itkStructurePreservingColorNormalizationFilter.h#L167-L168

Leengit commented 2 years ago

In particular, there is a check that the value is at least 3, so that may need some fixing.

https://github.com/InsightSoftwareConsortium/ITKColorNormalization/blob/c97b16571d2dbc268a305f8465eb58bc337e83d5/include/itkStructurePreservingColorNormalizationFilter.hxx#L38

https://github.com/InsightSoftwareConsortium/ITKColorNormalization/blob/c97b16571d2dbc268a305f8465eb58bc337e83d5/include/itkStructurePreservingColorNormalizationFilter.hxx#L138-L139