search

InsightSoftwareConsortium / ITKColorNormalization

Structure preserving color normalization on H&E images using a reference image
Apache License 2.0
18 stars 5 forks source link

Allow Python to catch errors #38

Open Leengit opened 2 years ago

Leengit commented 2 years ago

The current use of itkAssertOrThrowMacro to report errors, such as inputs that cannot be processed, is not caught by a Python try-except block. We want a solution where the Python program can recover from these errors.

andreped commented 2 years ago

That would be a great feature. I was looking into using ITKColorNormalization in my DP workflows, but I was unable to as it seemed to crash too often, with no simple way to catch these errors, as fair as I remember.

I could test a proposed solution in a typical workflow when it is ready.

Leengit commented 2 years ago

https://github.com/InsightSoftwareConsortium/ITK/pull/3479 should fix this issue. However, I nonetheless recommend that we use if (!success) { itkGenericExceptionMacro(message); } to replace itkAssertOrThrowMacro(success, message); in ITKColorNormalization code.