InsightSoftwareConsortium / ITKColorNormalization

Structure preserving color normalization on H&E images using a reference image
Apache License 2.0
18 stars 5 forks source link

ENH: Bump to ITK v5.3.0 with reusable workflow #42

Closed tbirdso closed 1 year ago

tbirdso commented 1 year ago

Bumps package version to reference ITK v5.3.0. Also consolidates CI testing in ITK reusable workflow for easier maintenance.

Closes https://github.com/InsightSoftwareConsortium/ITKColorNormalization/issues/41

dzenanz commented 1 year ago

I guess we need to update the copyright headers too:

1/3 Test #1: StructurePreservingColorNormalizationKWStyleTest ......***Failed    0.01 sec
/home/runner/work/ITKColorNormalization/ITKColorNormalization/include/itkStructurePreservingColorNormalizationFilter.h:9: error: Header mismatch: ://www.apache.org/licenses/LICENSE-2.0.txt (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h
/home/runner/work/ITKColorNormalization/ITKColorNormalization/include/itkStructurePreservingColorNormalizationFilter.hxx:9: error: Header mismatch: ://www.apache.org/licenses/LICENSE-2.0.txt (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h
/home/runner/work/ITKColorNormalization/ITKColorNormalization/test/itkStructurePreservingColorNormalizationFilterTest.cxx:9: error: Header mismatch: ://www.apache.org/licenses/LICENSE-2.0.txt (s://www.apache.org/licenses/LICENSE-2.0.txt) : Utilities/KWStyle/ITKHeader.h
tbirdso commented 1 year ago

Looks like Windows jobs are consistently failing to fetch the appropriate tarball, will need to investigate.

EDIT: Windows jobs seem to be successfully pulling archives now, guess there was a download issue earlier?