Open thewtex opened 3 years ago
This was indeed a very, quick temporal solution, since it wasn't a priority back then. But I'll now try to fix this issue in the itkTransformixFilter file in elastix.
How is the python itk.elastix_registration_method() defined (how does it know which functions to call in order)? Is this automatically done with swig or is it defined as a c++ method like in SimpleElastix? In the swig case: What are the ruled for this automatic swig python wrapping? And in the SimpleElastix case: In which file is it defined? (I haven't found it so far)
The itk.elastix_registration_method
function is automatically generated from the itk::ElastixRegistrationMethod
class. Indexed input's and output's to that class become the position args
. The Set*
methods become the kwargs
(also supporting snake_case). For SimpleElastix, it was a different, involved manual process.
And how are the internal function calls and the output of the function generated?
@thewtex Where did you get this error? I can't reproduce it locally (windows and mac) nor on the CI
@ViktorvdValk to reproduce the error, uncomment:
Yes, but that doesn't give me the error, not on the CI, nor on windows or mac. See https://github.com/InsightSoftwareConsortium/ITKElastix/compare/transformix_jacobian
@ViktorvdValk interesting.. could a PR please be created to enable the test in CI, please?
@N-Dekker has this been addressed with elastix 0.16.0?
Also seems to be not working in
itkTransformFilterTest.py
, commented in #109