search

InsightSoftwareConsortium / ITKIOOMEZarrNGFF

ITK IO for images stored in OME-Zarr format.
Apache License 2.0
9 stars 5 forks source link

STYLE: Move three internal helper functions into the unnamed namespace #72

Closed N-Dekker closed 1 month ago

N-Dekker commented 2 months ago

Moved writeJson, jsonRead, and addCoordinateTransformations into the unnamed namespace of "itkOMEZarrNGFFImageIO.cxx".

Following C++ Core Guidelines, May 11, 2024, "Use an unnamed (anonymous) namespace for all internal/non-exported entities", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf22-use-an-unnamed-anonymous-namespace-for-all-internalnon-exported-entities

N-Dekker commented 2 months ago

@dzenanz Some CI failures from build-macos-arm-py (10) from https://github.com/InsightSoftwareConsortium/ITKIOOMEZarrNGFF/actions/runs/10683486429/job/29611671206?pr=72#step:8:198

Fetching Python frameworks
./macpython-download-cache-and-build-module-wheels.sh: line 81: /Users/svc-dashboard/D/P/ITKPythonPackage/scripts/macpython-install-python.sh: No such file or directory
Building module wheels
./macpython-download-cache-and-build-module-wheels.sh: line 85: /Users/svc-dashboard/D/P/ITKPythonPackage/scripts/macpython-build-module-wheels.sh: No such file or directory

Do you have a clue? At least I think they are unrelated to this pull request 😇

dzenanz commented 2 months ago

https://github.com/InsightSoftwareConsortium/ITKMontage suffers from the same error, I don't know what broke, or how. What are the chances for you to get to it this week?

dzenanz commented 2 months ago

I might get to it next week, unless someone else gets to it before then.

dzenanz commented 2 months ago

Ahh, someone else is already on it: https://github.com/InsightSoftwareConsortium/ITKPythonPackage/pull/283 What a pleasure 😄

N-Dekker commented 1 month ago

@dzenanz Can you please rerun the CI for build-macos-arm-py, for this pull request? Or otherwise just merge, and pray that it's okay 😺

dzenanz commented 1 month ago

The fix is ready. Let me apply it to this repo too.

dzenanz commented 1 month ago

I am hoping this should be enough to fix it: #73.

dzenanz commented 1 month ago

Rebasing on main should fix CI.

N-Dekker commented 1 month ago

Now Build, test, package / build-windows-python-packages (8) fails, saying:


Invoke-WebRequest: D:\a\im\windows-download-cache-and-build-module-wheels.ps1:64
Line |
  64 |    Invoke-WebRequest -Uri "https://github.com/InsightSoftwareConsortiu …
     |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | One or more errors occurred. (The response ended prematurely. (ResponseEnded))
Error: Process completed with exit code 1.

At https://github.com/InsightSoftwareConsortium/ITKIOOMEZarrNGFF/actions/runs/10744126899/job/29800364622?pr=72#step:8:86

Any clue?

dzenanz commented 1 month ago

That is most likely some network hiccup. We can re-run failed tests one the others finish running.