search

InsightSoftwareConsortium / ITKModuleTemplate

A template to start an ITK Module
https://itk.org/ITKSoftwareGuide/html/Book1/ITKSoftwareGuide-Book1ch9.html#x50-1430009
Apache License 2.0
12 stars 16 forks source link

ENH: Update CI builds systems from Ubuntu 18.04 to 20.04 #110

Closed thewtex closed 3 years ago

thewtex commented 3 years ago

There are KWStyle warnings to address in KWStyle -> ITK before this update:

https://open.cdash.org/viewBuildError.php?type=1&buildid=7145449

KWStyle/kwsCheckLineLength.cxx:83:27: warning: '%ld' directive writing between 1 and 20 bytes into a region of size 10 [-Wformat-overflow=]

Warning | KWStyle/kwsCheckLineLength.cxx:83:26: note: directive argument in the range [-9223372036854775808, 9223372036854775806]
-- | --
thewtex commented 3 years ago

KWStyle needs to be patched:

https://github.com/Kitware/KWStyle

Then updated in ITK.

dzenanz commented 3 years ago

https://github.com/InsightSoftwareConsortium/ITK/pull/2526 should fix KWStyle warnings.

thewtex commented 3 years ago

@dzenanz awesome!!

thewtex commented 3 years ago

:clap: @dzenanz , addressed with 5.2.1