search

InsightSoftwareConsortium / ITKModuleTemplate

A template to start an ITK Module
https://itk.org/ITKSoftwareGuide/html/Book1/ITKSoftwareGuide-Book1ch9.html#x50-1430009
Apache License 2.0
12 stars 16 forks source link

ENH: Update ITK Python package git commit hash in build, test workflow #157

Closed jhlegarreta closed 3 months ago

jhlegarreta commented 5 months ago

Update the ITK Python package git commit hash in the build, test GitHub actions workflow file for both the project itself and the cookiecutter module template file.

jhlegarreta commented 5 months ago

~Updating the cookiecutter not done yet: depends on~ https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/pull/76

Done in 8912a0d.

jhlegarreta commented 5 months ago

Despite Linux Python packages reporting a successful outcome, there are errors in the build, e.g. https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/actions/runs/7962302110/job/21735464511?pr=157#step:9:663

that seem to be related to the std library and the compiler (?).

They were not present in the main builds, e.g.: https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/actions/runs/7467310771/job/20320558474

They are not present in non-Python builds, but the errors stem from an #include <string> statement in itkMacro.h, which should be compiled in non-Python builds as well.

The macOS Python package failure seems to be related to a path not being found, and it looks like that path corresponds to a mismatched Python version: https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/actions/runs/7962302110/job/21735463852?pr=157#step:8:1505

jhlegarreta commented 3 months ago

Superseded by PR #158. Probably fixes to the ITKRemoteModuleBuildTestPackageAction and ITKPythonPackage repositories also helped. Closing as no longer relevant.