InsightSoftwareConsortium / ITKModuleTemplate

A template to start an ITK Module
https://itk.org/ITKSoftwareGuide/html/Book1/ITKSoftwareGuide-Book1ch9.html#x50-1430009
Apache License 2.0
12 stars 16 forks source link

ENH: Fix `Node.js` warnings linked to GitHub actions #164

Closed jhlegarreta closed 1 week ago

jhlegarreta commented 2 weeks ago

Fix Node.js warnings linked to GitHub actions: bump actions/checkout@v4.

Take advantage of the commit to bump upload-artifact@v4 and actions/setup-python@v5.

Fixes:

Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3.
For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

raised for example in: https://github.com/InsightSoftwareConsortium/ITKTrimmedPointSetRegistration/actions/runs/9753007352

jhlegarreta commented 2 weeks ago

Not sure where this https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/actions/runs/9768626552/job/26966536773?pr=164#step:9:21

comes from as: https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/blob/v5.4.0/.github/workflows/build-test-package-python.yml#L196

Unless the ${{ matrix.python3-minor-version }} variable is empty.

dzenanz commented 2 weeks ago

MacOS one builds multiple wheels. MacOSWheels.zip artifact has the following content:

Screenshot 2024-07-03 12 22 12
jhlegarreta commented 2 weeks ago

Thanks for the investigation @dzenanz.

The issue comes from https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/blob/7581a150c6ab839183ab656870ecda80d01fd684/.github/workflows/build-test-package.yml#L256

It is the outer GHA workflow that is creating multiple artifact (one for each Python version) with the same name. It does not happen for Linux and Windows because:

https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/blob/7581a150c6ab839183ab656870ecda80d01fd684/.github/workflows/build-test-package.yml#L327 https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/blob/7581a150c6ab839183ab656870ecda80d01fd684/.github/workflows/build-test-package.yml#L208

PR #165.