search

InsightSoftwareConsortium / ITKPerformanceBenchmarking

Real-world tests to benchmark ITK performance.
https://www.insight-journal.org/browse/publication/972
Apache License 2.0
2 stars 8 forks source link

ENH: Bump ITK to latest commit in `master` #91

Closed jhlegarreta closed 3 years ago

jhlegarreta commented 3 years ago

Bump ITK to latest commit in master.

Fixes:

[1845/2161] Building C object Modules\ThirdParty\OpenJPEG\src\openjpeg\CMakeFiles\itkopenjpeg.dir\event.c.obj

FAILED: Modules/ThirdParty/OpenJPEG/src/openjpeg/CMakeFiles/itkopenjpeg.dir/event.c.obj

D:\a\ITKPerformanceBenchmarking\ITK\Modules\ThirdParty\OpenJPEG\src\openjpeg\opj_includes.h(106):
error C2169: 'lrintf': intrinsic function, cannot be defined

reported in https://github.com/InsightSoftwareConsortium/ITKPerformanceBenchmarking/pull/90/checks?check_run_id=3571426392#step:8:2707

jhlegarreta commented 3 years ago

Cross-referencing ITK PR 2388.

One this one gets hopefully merged, PR #90 should succeed after rebasing on master.

jhlegarreta commented 3 years ago

Build failures are unrelated to this patch set/ITK builds successfully; errors are related to the module itself not being built appropriately. I think it should be addressed separately.