BUG: Remove zstd compression args incompatible with 1.2.0

InsightSoftwareConsortium / ITKPythonPackage

A setup script to generate ITK Python Wheels

https://itkpythonpackage.readthedocs.io

Apache License 2.0

64 stars 22 forks source link

BUG: Remove zstd compression args incompatible with 1.2.0 #190

Closed tbirdso closed 2 years ago

tbirdso commented 2 years ago

Comparing the --help output between zstd 1.2.0 and 1.5.2 shows that the --long option is not supported by the former. Without this option the Linux tarball compresses to 1.88 GiB which is less than the 2 GiB limit.

In the future we will need to upgrade the zstd version we are distributing to ITK external modules for building Python wheels so that they can take advantage of new, advanced compression flags. For now it seems we can stick with zstd 1.2.0.

tbirdso commented 2 years ago

Resolves https://github.com/InsightSoftwareConsortium/ITKPythonBuilds/issues/1

tbirdso commented 2 years ago

I am surprised we are still under 2GB.

Barely, yes. May be good to plan for zstd upgrade in the next release or two.

tbirdso commented 2 years ago

Good news and bad news:

v5.3rc04 archive on macOS without --long compression flag clocks in at 2.06 GB, making it ever so slightly too big to upload as a Github artifact (bad)
The macOS build script for external modules installs the latest zstd from homebrew, which is 5.2.1, which supports the --long flag (good)

Will subsequently investigate getting external modules to decompress archive with --long flag.

tbirdso commented 2 years ago

@thewtex As this is a relatively small change that is blocking ITK v5.3rc04 wheels, and has been tested on computron, I am going to go ahead and merge. Will keep an eye on CI for responsive fixes as necessary.