search

InsightSoftwareConsortium / ITKPythonPackage

A setup script to generate ITK Python Wheels
https://itkpythonpackage.readthedocs.io
Apache License 2.0
63 stars 21 forks source link

BUG: Revert to valid `manylinux2014-x64` image tag #240

Closed tbirdso closed 1 year ago

tbirdso commented 1 year ago

While manylinux_2_28 and manylinux2014 images are typically tagged together, a recent manylinux_2_28 release addressing a _2_28 toolset compatibility issue was not paired with a manylinux2014 release. This commit updates Linux build scripts to decouple the tag used for each image.

See also: https://hub.docker.com/u/dockcross

tbirdso commented 1 year ago

This issue was not caught because docker failed silently in ITKSplitComponents in the most recent tag bump, will open an issue in ITKRemoteModuleBuildTestPackageAction to ensure that a docker failure results in a failed job.

https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3632771768/jobs/6129000489

~/work/ITKSplitComponents/ITKSplitComponents
Unable to find image 'dockcross/manylinux2014-x64:20221205-459c9f0' locally
docker: Error response from daemon: manifest for dockcross/manylinux2014-x64:20221205-459c9f0 not found: manifest unknown: manifest unknown.
See 'docker run --help'.
tbirdso commented 1 year ago

Seeing successful ITKSplitComponents 2014 builds with changes applied: https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3642021820/jobs/6148645321

tbirdso commented 1 year ago

Entered https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/issues/24