search

InsightSoftwareConsortium / ITKPythonPackage

A setup script to generate ITK Python Wheels
https://itkpythonpackage.readthedocs.io
Apache License 2.0
63 stars 21 forks source link

ENH: Modular archive download script on Linux #241

Closed tbirdso closed 1 year ago

tbirdso commented 1 year ago

Separates step for pulling build artifacts into a standalone script that is called by the central download-and-build script. The modular approach allows ITK modules with more complex build steps (OpenCL, etc) to use the download script directly instead of forking and altering the download script, thus reducing the maintenance burden for those ITK modules.

Local test has passed, will test on ITKSplitComponents before merge.

EDIT: Testing at https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3676857336

tbirdso commented 1 year ago

This change is in support of https://github.com/InsightSoftwareConsortium/ITKCLEsperanto/issues/50 which previously forked ITKPythonPackage's manylinux download script.

tbirdso commented 1 year ago

ITKSplitComponents Linux tests passed: https://github.com/InsightSoftwareConsortium/ITKSplitComponents/actions/runs/3676857336/attempts/1

Windows failures are unrelated as this PR solely deals with Linux scripts. I believe failures are due to these changes being in my fork at tbirdso/ITKPythonPackage.