search

InsightSoftwareConsortium / ITKPythonPackage

A setup script to generate ITK Python Wheels
https://itkpythonpackage.readthedocs.io
Apache License 2.0
63 stars 21 forks source link

ENH: Name and type command line options of Windows module PowerShell script #252

Closed SimonRit closed 1 year ago

SimonRit commented 1 year ago

This PR aims at improving the management of arguments in windows-download-cache-and-build-module-wheels.ps1 following problems encountered in RTKConsortium/RTK#535, namely passing multiple cmake options on the command line. The difference in the behaviors of PowerShell and Python args calls for another scripting language in my opinion (see #250 discussion) but this PR is an improvement over #248 in terms of clarity and consistency with other platforms. It is not backward compatible with it but that is probably ok since it is a recent change. See https://github.com/RTKConsortium/RTK/actions/runs/4243933294/jobs/7377339692 and https://github.com/RTKConsortium/RTK/actions/runs/4243933347 for successful use.

SimonRit commented 1 year ago

(The last force-push is only a slight change of the doc.)