InsightSoftwareConsortium / ITKPythonPackage

A setup script to generate ITK Python Wheels
https://itkpythonpackage.readthedocs.io
Apache License 2.0
64 stars 22 forks source link

Exclude libraries from auditwheel #266

Closed SimonRit closed 7 months ago

SimonRit commented 7 months ago

This PR

SimonRit commented 7 months ago

cc @LucasGandel

LucasGandel commented 7 months ago

The change to use the new --exclude option looks good, thanks a lot! I can't tell for the LD_LIBRARY_PATH change though.

SimonRit commented 7 months ago

I can't tell for the LD_LIBRARY_PATH change though.

I made it because auditwheel could not find the shared libraries otherwise. Maybe it was working before thanks to the whitelist? I honestly don't know why...

dzenanz commented 7 months ago

How does this change in light of this PR being merged? I tried using it here, without much luck.

SimonRit commented 7 months ago

without much luck.

The error message in the failing build seems unrelated Could NOT find SWIG (missing: SWIG_DIR) I'm not sure what's the problem here...

dzenanz commented 7 months ago

Maybe it is related to 96e34770ba4d4a989eb235afc15e68439c5a94c3?

SimonRit commented 7 months ago

Maybe it is related to 96e3477?

Possibly but I could not figure out why the CudaCommon CI had a different cmake command line, with the new options of this commit and not the former one as yours.