Scikit build core - Githubissues

thewtex commented 3 months ago

Closes #217

thewtex commented 3 months ago

@jcfr @henryiii

❯ for ff in dist/*.whl; do abi3audit --assume-minimum-abi3 3.11 $ff; done
[10:12:35] 🤷 nothing auditable found in dist/itk-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl    [10:12:39] 💁 itk_core-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 34 extensions scanned; 0 ABI 
           version mismatches and 0 ABI violations found                                         
[10:12:42] 💁 itk_filtering-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 22 extensions scanned; 0
           ABI version mismatches and 0 ABI violations found                                     
[10:12:45] 💁 itk_io-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 17 extensions scanned; 0 ABI   
           version mismatches and 0 ABI violations found                                         
[10:12:48] 💁 itk_numerics-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 13 extensions scanned; 0 
           ABI version mismatches and 0 ABI violations found                                     
[10:12:49] 💁 itk_registration-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 5 extensions scanned;
           0 ABI version mismatches and 0 ABI violations found                                   
[10:12:50] 💁 itk_segmentation-5.4rc3-cp311-abi3-manylinux_2_28_x86_64.whl: 5 extensions scanned;
           0 ABI version mismatches and 0 ABI violations found

:man_singer: !

thewtex commented 3 months ago

@jcfr @henryiii thanks for the review! Suggestions integrated with local changes.

I tested against the ITK Sphinx Examples

3.9 wheels against a 3.9 environment -- all tests pass :green_heart:
3.11 wheels against a 3.11 environment -- all tests pass :green_heart: :sparkler:
3.11 wheels against a 3.12 environment -- all tests pass :green_heart: :guitar: :sparkle:

thewtex commented 3 months ago

Voila, Windows:

MINGW64 /c/P/IPP (scikit-build-core)
$ ./venv-311-x64/Scripts/abi3audit.exe --assume-minimum-abi3 3.11 dist/*.whl
[14:38:08] 💁 itk_filtering-5.4rc3-cp311-abi3-win_amd64.whl: 22 extensions scanned; 0 ABI version mismatches and 0 ABI
           violations found
[14:39:13] 💁 itk_core-5.4rc3-cp311-abi3-win_amd64.whl: 34 extensions scanned; 0 ABI version mismatches and 0 ABI violations
           found
[14:40:19] 💁 itk_numerics-5.4rc3-cp311-abi3-win_amd64.whl: 13 extensions scanned; 0 ABI version mismatches and 0 ABI
           violations found
           🤷 nothing auditable found in dist/itk-5.4rc3-cp311-abi3-win_amd64.whl
[14:40:32] 💁 itk_segmentation-5.4rc3-cp311-abi3-win_amd64.whl: 5 extensions scanned; 0 ABI version mismatches and 0 ABI
           violations found
[14:40:42] 💁 itk_io-5.4rc3-cp311-abi3-win_amd64.whl: 17 extensions scanned; 0 ABI version mismatches and 0 ABI violations
           found
[14:41:03] 💁 itk_registration-5.4rc3-cp311-abi3-win_amd64.whl: 5 extensions scanned; 0 ABI version mismatches and 0 ABI
           violations found

thewtex commented 3 months ago

And mac:

❯ abi3audit --assume-minimum-abi3 3.11 dist/*abi3*.whl
[14:50:19] 💁 itk_registration-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 5    
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:21] 💁 itk_core-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 34 extensions
           scanned; 0 ABI version mismatches and 0 ABI violations found      
[14:50:22] 💁 itk_numerics-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 13       
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
           💁 itk_segmentation-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 5    
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:24] 💁 itk_filtering-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 22      
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:25] 💁 itk_registration-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 5    
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
           🤷 nothing auditable found in                                     
           dist/itk-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl                  
[14:50:26] 💁 itk_io-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 17 extensions  
           scanned; 0 ABI version mismatches and 0 ABI violations found      
[14:50:29] 💁 itk_core-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 34 extensions
           scanned; 0 ABI version mismatches and 0 ABI violations found      
           🤷 nothing auditable found in                                     
           dist/itk-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl                  
           💁 itk_segmentation-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 5    
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:30] 💁 itk_numerics-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 13       
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found                                                             
[14:50:32] 💁 itk_io-5.4rc3-cp311-abi3-macosx_11_0_arm64.whl: 17 extensions  
           scanned; 0 ABI version mismatches and 0 ABI violations found      
[14:50:33] 💁 itk_filtering-5.4rc3-cp312-abi3-macosx_11_0_arm64.whl: 22      
           extensions scanned; 0 ABI version mismatches and 0 ABI violations 
           found

InsightSoftwareConsortium / ITKPythonPackage

Scikit build core #267