search

InsightSoftwareConsortium / ITKPythonPackage

A setup script to generate ITK Python Wheels
https://itkpythonpackage.readthedocs.io
Apache License 2.0
64 stars 22 forks source link

BUG: Fix CMake options scikit-build-core on macOS and Linux #275

Closed SimonRit closed 4 months ago

SimonRit commented 4 months ago

This is propagating to MacOS and Linux what's in Windows: https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/windows_build_module_wheels.py#L99

The Linux version has been tested in https://github.com/RTKConsortium/ITKCudaCommon/actions/runs/9275896116/job/25521657471. I haven't tested MacOS' version.

SimonRit commented 4 months ago

I have a bug on Windows (see here, the string is not adequately handled) so you may want to wait the patch before merging

SimonRit commented 4 months ago

I have a bug on Windows (see here, the string is not adequately handled) so you may want to wait the patch before merging

No sorry, the problem is not in ITKPythonPackage I believe, this PR can be merged.