InsightSoftwareConsortium / ITKRemoteModuleBuildTestPackageAction

A composite GitHub Action to build, test, and package, ITK remote modules
Apache License 2.0
3 stars 6 forks source link

ENH: Introduce manylinux option with ARM #17

Closed tbirdso closed 1 year ago

tbirdso commented 2 years ago

Exposes input parameter to allow the user to build for multiple Linux toolsets and target architectures via available manylinux docker images.

Depends on ARM support introduced in ITKPythonPackage: https://github.com/InsightSoftwareConsortium/ITKPythonPackage/pull/236

tbirdso commented 1 year ago

Updated with respect to #46 such that jobs are dynamically scheduled based on requested platforms. Linux jobs now produce one wheel per job.

Advantages of this approach:

Disadvantage of this approach:

Testing at https://github.com/tbirdso/ITKSplitComponents/actions/runs/3840735170/jobs/6540141356 .

dzenanz commented 1 year ago

Consider shortening the names from build-{OS}-python-packages-{furtherSpecs} to {OS}-packages-{furtherSpecs} or {OS}-py-{furtherSpecs}. The names overflow the horizontal space on the left panel, and the important parts are cut off.

tbirdso commented 1 year ago

@dzenanz Good call. I have shortened to build-linux-py to preserve the "{verb}-{noun}" format for job titles.

EDIT: Much better: https://github.com/tbirdso/ITKSplitComponents/actions/runs/3840941792

tbirdso commented 1 year ago

@thewtex @dzenanz ping for re-review

tbirdso commented 1 year ago

Force-pushed documentation updates.

I would prefer shortening Windows job names too, but this is good as is.

Given that this is stable and tests have passed I will move forward as-is, but I have no issue with shortening other job names in the future.