search

InsightSoftwareConsortium / ITKRemoteModuleBuildTestPackageAction

A composite GitHub Action to build, test, and package, ITK remote modules
Apache License 2.0
3 stars 6 forks source link

WIP: Fix ITK_DIR for cxx workflows #23

Open tbirdso opened 1 year ago

tbirdso commented 1 year ago

Resolves issue where ITK_DIR was not updated for Windows shortened path lengths changes.

Issue observed at https://github.com/KitwareMedical/ITKMorphologicalContourInterpolation/actions/runs/3634013547/jobs/6131669519

tbirdso commented 1 year ago

Out of caution I'll wait for https://github.com/KitwareMedical/ITKMorphologicalContourInterpolation/actions/runs/3634196177/jobs/6132042226 to complete successfully before merging.

tbirdso commented 1 year ago

Seeing failures in https://github.com/KitwareMedical/ITKMorphologicalContourInterpolation/actions/runs/3634196177/jobs/6132042226, it seems that ITK is being built twice. Investigating.

tbirdso commented 1 year ago

Output from https://github.com/KitwareMedical/ITKMorphologicalContourInterpolation/actions/runs/3640706239/jobs/6148482086 shows that Linux and MacOS builds are running as expected but Windows is failing. It is expected that ITK is built first, then the ITK module is built and tested with any warnings or errors reported to CDash. In the Windows case ITK builds first, but then for some reason ITK builds again and its tests are run as if it were the module under test, with ITK's warnings reported to CDash. Currently unclear why this happens.

The sole difference in CDash configuration that I can find between previous and updated Windows behavior is that CTEST_CHECKOUT_COMMAND is being implicitly populated in only the Windows version.

CTEST_CHECKOUT_COMMAND=["D:/a/_temp/-111744671/cmake-3.22.2-windows-x86_64/bin/cmake.exe" -P "/d/a/im/../im-init.cmake"]
tbirdso commented 1 year ago

I've opened https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/pull/25 to revert the incomplete changes for shortening path names that are currently breaking main. Will use this branch and PR to track continued efforts to fix that procedure.