search

InsightSoftwareConsortium / ITKRemoteModuleBuildTestPackageAction

A composite GitHub Action to build, test, and package, ITK remote modules
Apache License 2.0
3 stars 5 forks source link

Validate build output fails in my external module #77

Open dyollb opened 5 months ago

dyollb commented 5 months ago

My external module cannot be installed from pypi on my M2 mac, with python 3.10. I noticed some other external modules can be installed, so I tried to update the hash for the github workflows. However, I am getting errors in the "Validate build output" step. https://github.com/dyollb/ITKDissolve/actions/runs/8405014484/job/23017240978

InvalidDistribution: Cannot find file (or expand pattern):
'dist/itk_cp38manylinux_2_28*x86_64.whl'

The failure happens in the linux 3.8 python build. The macos and windows builds succeed.

I did not make any code changes, except for the has in the github workflows.

Any idea @thewtex?

dyollb commented 5 months ago

Ok, so it seems that ITKElastix was probably manually built on arm64 macos. So even if the linux "Validate build output" error is fixed I still won't have a wheel for my mac m2 from the CI.

thewtex commented 5 months ago

@dyollb GitHub Actions recently added support for Apple Silicon ARM GitHub runners. We will look to add support for generating ARM mac wheels for your package in the upcoming release.

thewtex commented 5 months ago

@dyollb updating your configuration to point to the HEAD of the v5.4.0 branch on this repository, df1df6398389fa1a99d169b1264b9647d2164dd0, adds ARM macOS support.

It is also recommended to upgrade setup.py to pyproject.toml per https://github.com/InsightSoftwareConsortium/ITKModuleTemplate/pull/158

dyollb commented 5 months ago

@thewtex Thanks for the update! this is great news. Looking forward to trying it out.