InsightSoftwareConsortium / ITKSphinxExamples

Cookbook examples for the Insight Toolkit documented with Sphinx
https://examples.itk.org
Apache License 2.0
53 stars 63 forks source link

ENH: Switch Github Actions macOS environment #391

Closed jhlegarreta closed 1 year ago

jhlegarreta commented 1 year ago

Switch Github Actions macOS environment version to macos-11.

macOS-10.15 is being deprecated and support will end by 8/30/2022: https://github.com/actions/virtual-environments/issues/5583

Related to recent warnings in the Azure Pipelines macOS environment being used in the main ITK repository: https://github.com/InsightSoftwareConsortium/ITK/pull/3532/commits/e5595dee1917e94ecc3c7f94873841b0f522d3c0

jhlegarreta commented 1 year ago

Ubuntu Superbuild and documentation build failures are unrelated: https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/runs/7705570903?check_suite_focus=true#step:8:21856 https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/runs/7705570705?check_suite_focus=true#step:9:26177

Both seem to be related to https://github.com/InsightSoftwareConsortium/ITK/issues/3528, as shown by the error trace

243: Test timeout computed to be: 1500
142: Traceback (most recent call last):
142:   File "/home/runner/work/Ex/src/Core/Common/EagerModuleLoadingPython/Code.py", line 30, in <module>
142:     import itk
142:   File "/home/runner/work/bld/itkpython/lib/python3.7/site-packages/itk/__init__.py", line 162, in <module>
142:     _initialize_module()
142:   File "/home/runner/work/bld/itkpython/lib/python3.7/site-packages/itk/__init__.py", line 132, in _initialize_module
142:     _base.itk_load_swig_module(module, sys.modules[__name__].__dict__)
142:   File "/home/runner/work/bld/itkpython/lib/python3.7/site-packages/itk/support/base.py", line 132, in itk_load_swig_module
142:     l_module = loader.load(swig_module_name)
142:   File "/home/runner/work/bld/itkpython/lib/python3.7/site-packages/itk/support/base.py", line 291, in load
142:     l_spec.loader.exec_module(l_module)  # pytype: disable=attribute-error
142:   File "/home/runner/work/bld/itkpython/lib/python3.7/site-packages/itk/support/../MeshToPolyDataPython.py", line 13, in <module>
142:     from . import _MeshToPolyDataPython
142: AttributeError: PyCapsule_Import "_ITKCommonPython._C_API" is not valid
428/701 Test #142: EagerModuleLoadingPythonTest .......................................................***Failed   46.74 sec

at https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/runs/7705570903?check_suite_focus=true#step:8:16344

dzenanz commented 1 year ago

Should we wait until that is fixed before merging this?

jhlegarreta commented 1 year ago

Should we wait until that is fixed before merging this?

I do not think so. Although merging is likely to render the CI badge as failing, the macOS-10.15 environment will anyways be unsupported by the end of the month.

dzenanz commented 1 year ago

@tbirdso is the fix expected before the end of the month?

tbirdso commented 1 year ago

@dzenanz I am not currently clear on the roadmap for addressing https://github.com/InsightSoftwareConsortium/ITK/issues/3528. I have pinged maintainers in that issue in regards to how it may impact the v5.3 roadmap.

thewtex commented 1 year ago

Thanks for this update, @jhlegarreta !

142: AttributeError: PyCapsule_Import "_ITKCommonPython._C_API" is not valid

@tbirdso addressed this via https://github.com/InsightSoftwareConsortium/ITKMeshToPolyData/pull/50

https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/pull/392 bumps to ITK 5.3 RC 4 -- a rebased after that is in will hopefully be green.

dzenanz commented 1 year ago

It looks like the checks are not running?

jhlegarreta commented 1 year ago

It looks like the checks are not running?

Not sure why. Re-triggered manually : https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/actions/runs/2876023121

Not sure whether they'll report back here.

jhlegarreta commented 1 year ago

Push-forced. Re-rerunning properly now.