InsightSoftwareConsortium / ITKSphinxExamples

Cookbook examples for the Insight Toolkit documented with Sphinx
https://examples.itk.org
Apache License 2.0
53 stars 65 forks source link

Fix python3 find package #394

Open hjmjohnson opened 2 years ago

hjmjohnson commented 2 years ago

Update to remove deprecated find_package(PythonLib) and find_package(PythonInterp) and the associated variables.

Use find_package(Python3) and its associated variables.

hjmjohnson commented 2 years ago

@dzenanz Thanks for the comment. I made this change, and also will be forcing ITK to 3.7 or greater soon.

github-actions[bot] commented 2 years ago

🎉 Published on https://examples.itk.org as production 🚀 Deployed on https://630001dd3a95cb430f50e569--itkexamples.netlify.app

thewtex commented 1 year ago

@hjmjohnson could this please be rebased on master?

jhlegarreta commented 1 year ago

@dzenanz Thanks for the comment. I made this change, and also will be forcing ITK to 3.7 or greater soon.

The CI workflow already uses 3.9, https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/blob/master/.github/workflows/build-test-publish.yml#L37

and Python 3.7 is 5 months from deprecation, so if a minimum version needs to be enforced, maybe it should be 3.8. At the same time: