search

InsightSoftwareConsortium / ITKSphinxExamples

Cookbook examples for the Insight Toolkit documented with Sphinx
https://examples.itk.org
Apache License 2.0
53 stars 63 forks source link

Itk 5.3.0 #402

Closed thewtex closed 1 year ago

thewtex commented 1 year ago

@dzenanz why is there a Windows warning:

D:\a\bld\ITK\Modules\ThirdParty\ZLIB\src\itkzlib-ng\crc32_braid.c(128): warning C4311: 'type cast': pointer truncation from 'const uint8_t *' to 'unsigned long'
dzenanz commented 1 year ago

why is there a Windows warning

The examples are probably using some combination of options which we don't routinely test.

Found it: examples use a different version of zlib, not the one bundled with ITK.

dzenanz commented 1 year ago

We rarely use/test ITK_LEGACY_SILENT option.

dzenanz commented 1 year ago

Maybe I was looking at the wrong build, and now the problem are 3 failing tests?

dzenanz commented 1 year ago

I issued a rerun of the failed jobs. With updated time, it will be easier to tell what is the problem.

dzenanz commented 1 year ago

The compile warnings are still there, D:\a\bld\ITK\Modules\ThirdParty\ZLIB\src\itkzlib-ng\crc32_braid.c(128): warning C4311: 'type cast': pointer truncation from 'const uint8_t *' to 'unsigned long' and /.../bld/ITKEx-build/src/Bridge/NumPy/ConvertNumPyArrayToitkImage/ConvertNumPyArrayToitkImage.ipynb:: WARNING: Pygments lexer name 'ipython3' is not known.

dzenanz commented 1 year ago

There is an outstanding PR to fix this in zlib-ng: https://github.com/zlib-ng/zlib-ng/pull/1371. I still don't know why it doesn't show up on our nightly builds.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB