search

InsightSoftwareConsortium / ITKThickness3D

An ITK module to compute 3D thickness
Apache License 2.0
39 stars 18 forks source link

COMP: Add the `override` keyword to overriding methods. #18

Closed jhlegarreta closed 5 years ago

jhlegarreta commented 5 years ago

Add the override keyword to overriding methods.

Fixes the dashboard errors:

include/itkBinaryThinningImageFilter3D.h:141:8: warning: 'PrintSelf'
overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]

and

include/itkBinaryThinningImageFilter3D.h:144:8: warning: 'GenerateData'
overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]

reported at: http://testing.cdash.org/viewBuildError.php?type=1&buildid=5818150

jhlegarreta commented 5 years ago

The module is building; the reported error is unrelated to the change:

3/4 Test #4: itkMedialThicknessImageFilter3DTest ...***Exception: SegFault  0.17 sec

It was being reported by CDash before the change and it will need to be fixed in another PR.

Merging.