search

InsightSoftwareConsortium / ITKThickness3D

An ITK module to compute 3D thickness
Apache License 2.0
39 stars 18 forks source link

STYLE: Pefer = default to explicitly trivial implementations #19

Closed jhlegarreta closed 5 years ago

jhlegarreta commented 5 years ago

This check replaces default bodies of special member functions with = default;. The explicitly defaulted function declarations enable more opportunities in optimization, because the compiler might treat explicitly defaulted functions as trivial.

Additionally, the C++11 use of = default more clearly expresses the intent for the special member functions.

jhlegarreta commented 5 years ago

The module is building; the reported error is unrelated to the change:

4/4 Test #4: itkMedialThicknessImageFilter3DTest ...***Exception: SegFault  0.72 sec

It was being reported by CDash before the change and it will need to be fixed in another PR.

Merging.